Added validation checks to password field in sign up form #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmajabhol
approved these changes
May 6, 2022
|
Hey @padmajabhol can you please merge this? |
I only review PRs. I don't think I should merge a PR before the approval of either of the mentors. Though I assure that every PR counts has a solid contribution regardless they are merged or not. |
Okay! I said this because another bug I worked on got committed to this PR. Issue #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds validation to the password field in the sign up form. Checks whether the password is 8 or more characters long, contains upper an lowercase letters and special characters using regex expression.
Fixes #143
Type of change
Please delete options that are not relevant.
Additional Context (Please include any Screenshots/gifs if relevant)
2022-04-20.15-01-05.mp4